D17438: [folder] Initialise LabelGenerator::m_labelMode

[David Edmundson]

davidedmundson created this revision.
davidedmundson added a reviewer: Plasma.
Herald added a project: Plasma.
Herald added a subscriber: plasma-devel.
davidedmundson requested review of this revision.

REVISION SUMMARY
It's giving big warnings in valgrind.

Ultimately I don't think it's a huge issue, as I think it gets bound later
and that rebuilds everything.

TEST PLAN
Another comment said 1 was the default

REPOSITORY
R119 Plasma Desktop

BRANCH
Plasma/5.14

REVISION DETAIL
https://phabricator.kde.org/D17438

AFFECTED FILES
containments/desktop/plugins/folder/labelgenerator.h

To: davidedmundson, #plasma
Cc: plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

[Kai Uwe Broulik]

broulik added a comment.


Do you have 98d38f9ffb607cebe439a5a8f9ed8e464db417c0 <https://phabricator.kde.org/R119:98d38f9ffb607cebe439a5a8f9ed8e464db417c0>?

REPOSITORY
R119 Plasma Desktop

REVISION DETAIL
https://phabricator.kde.org/D17438

To: davidedmundson, #plasma
Cc: broulik, plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

[David Edmundson]

davidedmundson abandoned this revision.
davidedmundson added a comment.


That patch needs backporting to stable.

I'll do that now.

REPOSITORY
R119 Plasma Desktop

REVISION DETAIL
https://phabricator.kde.org/D17438

To: davidedmundson, #plasma
Cc: broulik, plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart