D17467: digital-clock: Show events on expanding applet

[Kai Uwe Broulik]

broulik added inline comments.

INLINE COMMENTS

CalendarView.qml:55
monthView.resetToToday();
+ holidaysList.update();
}

I think this should check for `isExpanded` so it does not update the events (potentially heavy operation) when *closing*

REPOSITORY
R120 Plasma Workspace

REVISION DETAIL
https://phabricator.kde.org/D17467

To: mbehrendt
Cc: broulik, plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

[Marcus Behrendt]

mbehrendt updated this revision to Diff 47255.
mbehrendt added a comment.


only once set hasExpanded = true

REPOSITORY
R120 Plasma Workspace

CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D17467?vs=47252&id=47255

REVISION DETAIL
https://phabricator.kde.org/D17467

AFFECTED FILES
applets/digital-clock/package/contents/ui/CalendarView.qml

To: mbehrendt
Cc: broulik, plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

[Marcus Behrendt]

mbehrendt updated this revision to Diff 47256.
mbehrendt marked an inline comment as done.
mbehrendt added a comment.


fix typos

REPOSITORY
R120 Plasma Workspace

CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D17467?vs=47255&id=47256

REVISION DETAIL
https://phabricator.kde.org/D17467

AFFECTED FILES
applets/digital-clock/package/contents/ui/CalendarView.qml

To: mbehrendt
Cc: broulik, plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

[Marcus Behrendt]

mbehrendt created this revision.
Herald added a project: Plasma.
Herald added a subscriber: plasma-devel.
mbehrendt requested review of this revision.

REVISION SUMMARY
When expanding the digital-clock applet the holidayList is not updated, so that events for the current day are not shown.
In order to show the events for the current day after expansion one had to click on another day in the month view and then click back to the current day.

This patch fixes that by properly updating the holidaysList's model. It also reduces redundancy by putting the update routine in a separate function.

REPOSITORY
R120 Plasma Workspace

REVISION DETAIL
https://phabricator.kde.org/D17467

AFFECTED FILES
applets/digital-clock/package/contents/ui/CalendarView.qml

To: mbehrendt
Cc: plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

[Marcus Behrendt]

mbehrendt added a reviewer: Plasma.
mbehrendt added a comment.




REPOSITORY
R120 Plasma Workspace

REVISION DETAIL
https://phabricator.kde.org/D17467

To: mbehrendt, #plasma
Cc: broulik, plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart