Discussion:
D15423: System settings: make date/time format preview consistent
Oleg Solovyov
2018-09-11 12:36:39 UTC
Permalink
McPain created this revision.
McPain added a reviewer: hein.
Herald added a project: Plasma.
Herald added a subscriber: plasma-devel.
McPain requested review of this revision.

REVISION SUMMARY
BUG: 398493

REPOSITORY
R119 Plasma Desktop

REVISION DETAIL
https://phabricator.kde.org/D15423

AFFECTED FILES
kcms/formats/kcmformats.cpp

To: McPain, hein
Cc: plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart
Nathaniel Graham
2018-09-11 12:55:33 UTC
Permalink
ngraham added a comment.


Before-and-after screenshots can make a big difference in the reviewability of a patch like this. :)

REPOSITORY
R119 Plasma Desktop

REVISION DETAIL
https://phabricator.kde.org/D15423

To: McPain, hein
Cc: ngraham, plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart
Oleg Solovyov
2018-09-11 13:28:54 UTC
Permalink
McPain added a comment.


Before: F6252186: ОзПбражеМОе.png <https://phabricator.kde.org/F6252186>
After: F6252262: ОзПбражеМОе.png <https://phabricator.kde.org/F6252262>

REPOSITORY
R119 Plasma Desktop

REVISION DETAIL
https://phabricator.kde.org/D15423

To: McPain, hein
Cc: ngraham, plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart
Andres Betts
2018-09-11 14:19:18 UTC
Permalink
abetts added a comment.


+1

REPOSITORY
R119 Plasma Desktop

REVISION DETAIL
https://phabricator.kde.org/D15423

To: McPain, hein
Cc: abetts, ngraham, plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, sebas, apol, mart
Nathaniel Graham
2018-09-11 14:26:00 UTC
Permalink
ngraham added a reviewer: VDG.
ngraham added a comment.


Thanks, that helps!

REPOSITORY
R119 Plasma Desktop

REVISION DETAIL
https://phabricator.kde.org/D15423

To: McPain, hein, #vdg
Cc: abetts, ngraham, plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, sebas, apol, mart
Nathaniel Graham
2018-09-11 14:44:55 UTC
Permalink
ngraham accepted this revision as: VDG.
ngraham added a comment.


Looks good to me, and doesn't regress anything in any of the other locales I tried. I'll let @hein do a final review.

REPOSITORY
R119 Plasma Desktop

REVISION DETAIL
https://phabricator.kde.org/D15423

To: McPain, hein, #vdg
Cc: abetts, ngraham, plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, sebas, apol, mart
David Edmundson
2018-09-28 11:28:28 UTC
Permalink
davidedmundson added inline comments.

INLINE COMMENTS
kcmformats.cpp:322
+ str = m_ui->comboNumbers->currentData().toString();
+ nloc = str.isEmpty() ? QLocale(glob) : QLocale(str);
+
I don't understand, why is this sometimes empty?

REPOSITORY
R119 Plasma Desktop

REVISION DETAIL
https://phabricator.kde.org/D15423

To: McPain, hein, #vdg
Cc: davidedmundson, abetts, ngraham, plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, sebas, apol, mart
Oleg Solovyov
2018-12-07 08:47:22 UTC
Permalink
McPain added inline comments.

INLINE COMMENTS
davidedmundson wrote in kcmformats.cpp:322
I don't understand, why is this sometimes empty?
Sorry for delayed reply.

In KCMFormats::initCombo we add locales to combo boxes.
First we add a QString() for "No change" option and then we add all possible locales.

REPOSITORY
R119 Plasma Desktop

REVISION DETAIL
https://phabricator.kde.org/D15423

To: McPain, hein, #vdg
Cc: davidedmundson, abetts, ngraham, plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, sebas, apol, mart
Loading...