Discussion:
D17359: Fix use of QRegularExpressionMatch
Fabian Vogt
2018-12-04 19:36:33 UTC
Permalink
fvogt created this revision.
fvogt added reviewers: Plasma, ivan.
Herald added a project: Plasma.
fvogt requested review of this revision.

REVISION SUMMARY
isValid is always true in this case, leading to the wrong error message being
returned.

TEST PLAN
Opened the wizard, now it shows the correct error if a binary was
not found.

REPOSITORY
R845 Plasma Vault

BRANCH
Plasma/5.12

REVISION DETAIL
https://phabricator.kde.org/D17359

AFFECTED FILES
kded/engine/fusebackend_p.cpp

To: fvogt, #plasma, ivan
Cc: plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart
Fabian Vogt
2018-12-04 19:49:25 UTC
Permalink
This revision was automatically updated to reflect the committed changes.
Closed by commit R845:5d3face3c1bb: Fix use of QRegularExpressionMatch (authored by fvogt).

REPOSITORY
R845 Plasma Vault

CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D17359?vs=46866&id=46867

REVISION DETAIL
https://phabricator.kde.org/D17359

AFFECTED FILES
kded/engine/fusebackend_p.cpp

To: fvogt, #plasma, ivan
Cc: plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart
Loading...