D17420: [Device Notifier] Fix action button vertical alignment

[Thomas Surrel]

thsurrel created this revision.
thsurrel added a reviewer: VDG.
Herald added a project: Plasma.
Herald added a subscriber: plasma-devel.
thsurrel requested review of this revision.

REPOSITORY
R120 Plasma Workspace

BRANCH
arc_alignment (branched from master)

REVISION DETAIL
https://phabricator.kde.org/D17420

AFFECTED FILES
applets/devicenotifier/package/contents/ui/DeviceItem.qml

To: thsurrel, #vdg
Cc: plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

[Nathaniel Graham]

ngraham added inline comments.

INLINE COMMENTS

DeviceItem.qml:308
onClicked: actionTriggered()
+ y: mounted ? deviceLabel.height + (freeSpaceBar.height - height) / 2 - 2 : (deviceLabel.height + actionMessage.height - height) / 2
}

`- 2` looks like a magic number. Might that be better expressed as `units.smallSpacing / 2` instead?

REPOSITORY
R120 Plasma Workspace

REVISION DETAIL
https://phabricator.kde.org/D17420

To: thsurrel, #vdg
Cc: ngraham, plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

[Thomas Surrel]

thsurrel updated this revision to Diff 47080.
thsurrel added a comment.


No more magic :(

REPOSITORY
R120 Plasma Workspace

CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D17420?vs=47079&id=47080

BRANCH
arc_alignment (branched from master)

REVISION DETAIL
https://phabricator.kde.org/D17420

AFFECTED FILES
applets/devicenotifier/package/contents/ui/DeviceItem.qml

To: thsurrel, #vdg
Cc: ngraham, plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

[Andres Betts]

abetts added a comment.


Love it! +1

REPOSITORY
R120 Plasma Workspace

REVISION DETAIL
https://phabricator.kde.org/D17420

To: thsurrel, #vdg
Cc: abetts, ngraham, plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, sebas, apol, mart

[Nathaniel Graham]

ngraham accepted this revision.
ngraham added a comment.
This revision is now accepted and ready to land.


Works flawlessly! Very nice.

REPOSITORY
R120 Plasma Workspace

BRANCH
arc_alignment (branched from master)

REVISION DETAIL
https://phabricator.kde.org/D17420

To: thsurrel, #vdg, ngraham
Cc: abetts, ngraham, plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, sebas, apol, mart

[Thomas Surrel]

This revision was automatically updated to reflect the committed changes.
Closed by commit R120:2c541ac87c4d: [Device Notifier] Fix action button vertical alignment (authored by thsurrel).

REPOSITORY
R120 Plasma Workspace

CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D17420?vs=47080&id=47089

REVISION DETAIL
https://phabricator.kde.org/D17420

AFFECTED FILES
applets/devicenotifier/package/contents/ui/DeviceItem.qml

To: thsurrel, #vdg, ngraham
Cc: abetts, ngraham, plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, sebas, apol, mart