D17393: [Folder View] make file context menu consistent with Dolphin's

[Nathaniel Graham]

ngraham created this revision.
ngraham added a reviewer: Plasma.
Herald added a project: Plasma.
Herald added a subscriber: plasma-devel.
ngraham requested review of this revision.

REVISION SUMMARY
BUG: 401652
FIXED-IN: 5.15.0

TEST PLAN
Folder view now:

Matches Dolphin:

(the lack of a separator over Properties in Dolphin seems like a recent regression that I will go fix now, because it always had that before)

REPOSITORY
R119 Plasma Desktop

BRANCH
context-menu-consistency-with-dolphin (branched from master)

REVISION DETAIL
https://phabricator.kde.org/D17393

AFFECTED FILES
containments/desktop/plugins/folder/foldermodel.cpp

To: ngraham, #plasma
Cc: plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

[Nathaniel Graham]

ngraham updated this revision to Diff 47003.
ngraham added a comment.


Also give the Properties action a shortcut, so now the menu is 100% identical with Dolphin's

REPOSITORY
R119 Plasma Desktop

CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D17393?vs=47000&id=47003

BRANCH
context-menu-consistency-with-dolphin (branched from master)

REVISION DETAIL
https://phabricator.kde.org/D17393

AFFECTED FILES
containments/desktop/plugins/folder/foldermodel.cpp

To: ngraham, #plasma, hein
Cc: plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

[Anthony Fieroni]

anthonyfieroni added a comment.


+1

REPOSITORY
R119 Plasma Desktop

REVISION DETAIL
https://phabricator.kde.org/D17393

To: ngraham, #plasma, hein
Cc: anthonyfieroni, plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

[Eike Hein]

hein added a comment.


Can we patch Dolphin instead? I think the order there is pretty bad, with weird random dividers etc. (From the screenshots in the original user bug.) I prefer FV's.

REPOSITORY
R119 Plasma Desktop

REVISION DETAIL
https://phabricator.kde.org/D17393

To: ngraham, #plasma, hein
Cc: janpr, anthonyfieroni, plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

[Nathaniel Graham]

ngraham added a comment.


Hmm, I prefer the Dolphin one for the following reasons:

1. Having the the "open with" item near the top makes sense because it's likely the most commonly used item
2. Having the "open" items grouped together makes sense, since they're both similar actions, and all other platforms I'm familiar with have their context menu's "open" items on the top too
3. The greater use of separators is an asset, not a drawback: separators provide structure and help the mind distinguish between logical groups. In particular having cut/copy/paste separated from other items makes sense.
4. The current FV menu has bugs:
1. The top item is Open, but it uses an inappropriate icon and is duplicated by another superior Open with [app name] item buried in the middle of the context menu.
2. It doesn't show the Paste item unless there's something to paste. This is a HIG violation; we don't recommend modifying the visibility of inapplicable menu items; instead they should be disabled.
3. The Properties item doesn't have a keyboard shortcut

But if you're not convinced, perhaps we could ask #VDG <https://phabricator.kde.org/tag/vdg/> which of the following they prefer:

Current Folder View menu:
F6464047: Screenshot_20181208_073248.png <https://phabricator.kde.org/F6464047>

Current Dolphin menu:
F6460009: Dolphin.png <https://phabricator.kde.org/F6460009>

REPOSITORY
R119 Plasma Desktop

REVISION DETAIL
https://phabricator.kde.org/D17393

To: ngraham, #plasma, hein
Cc: janpr, anthonyfieroni, plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

[Jan Przybylak]

janpr added a comment.


I agree that Dolphin's menu makes more sense. If this turns out to be controversial, maybe the order should be easier to change, instead of having it hard coded...

REPOSITORY
R119 Plasma Desktop

REVISION DETAIL
https://phabricator.kde.org/D17393

To: ngraham, #plasma, hein
Cc: janpr, anthonyfieroni, plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart