Anthony Fieroni
2018-11-14 06:51:36 UTC
anthonyfieroni created this revision.
anthonyfieroni added reviewers: Plasma, davidedmundson.
Herald added a project: Plasma.
Herald added a subscriber: plasma-devel.
anthonyfieroni requested review of this revision.
REVISION SUMMARY
The problem is when date is changed we connect to source ex. dilbert:2018-11-14 but in other hand script (main.es) makes
if (comic.identifier.toString() == date.currentDate().toString()) {
comic.requestPage("http://dilbert.com/", comic.User, infos);
so provider do its job but dataengine does not have a data for us, cause identifier is dilbert: and we are not connected to, so dataUpdated is not called which cause busy indicator to eats cpu power. Another fix can be to have permanently connection to comic_name: to enter dataUpdated in any case.
REPOSITORY
R114 Plasma Addons
REVISION DETAIL
https://phabricator.kde.org/D16873
AFFECTED FILES
applets/comic/comic.cpp
To: anthonyfieroni, #plasma, davidedmundson
Cc: plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart
anthonyfieroni added reviewers: Plasma, davidedmundson.
Herald added a project: Plasma.
Herald added a subscriber: plasma-devel.
anthonyfieroni requested review of this revision.
REVISION SUMMARY
The problem is when date is changed we connect to source ex. dilbert:2018-11-14 but in other hand script (main.es) makes
if (comic.identifier.toString() == date.currentDate().toString()) {
comic.requestPage("http://dilbert.com/", comic.User, infos);
so provider do its job but dataengine does not have a data for us, cause identifier is dilbert: and we are not connected to, so dataUpdated is not called which cause busy indicator to eats cpu power. Another fix can be to have permanently connection to comic_name: to enter dataUpdated in any case.
REPOSITORY
R114 Plasma Addons
REVISION DETAIL
https://phabricator.kde.org/D16873
AFFECTED FILES
applets/comic/comic.cpp
To: anthonyfieroni, #plasma, davidedmundson
Cc: plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart