D16918: [brightnesscontrol] Do not change screen brightness on invalid values

[Anthony Fieroni]

anthonyfieroni created this revision.
anthonyfieroni added reviewers: Plasma, broulik.
Herald added a project: Plasma.
Herald added a subscriber: plasma-devel.
anthonyfieroni requested review of this revision.

REVISION SUMMARY
The problem:

1. Unplug laptop power supply
2. On screen energy saving in settings
3. Uncheck screen brightness (on all profiles or on that will be loaded)
4. Wait minutes display to do off (not dimmed)
5. Plug power supply without display on
6. When it's on, screen brightness is 100%

Probably it's depends of backend (intel in my case) on dpms it returns *garbage* values even on max brightness (it's still not tested)

The solution:
Trying to cache max brightness level and denied to change screen brightness on garbage values

TEST PLAN
@broulik if you have better solution, i'll test it

REPOSITORY
R122 Powerdevil

REVISION DETAIL
https://phabricator.kde.org/D16918

AFFECTED FILES
daemon/actions/bundled/brightnesscontrol.cpp
daemon/actions/bundled/brightnesscontrol.h

To: anthonyfieroni, #plasma, broulik
Cc: broulik, plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

[Anthony Fieroni]

anthonyfieroni added a comment.


So i made simple script to test, it looks like the problem is that

xset dpms force off
sleep 1
cat /sys/class/backlight/intel_backlight/max_brightness
cat /sys/class/backlight/intel_backlight/brightness
cat /sys/class/backlight/intel_backlight/actual_brightness

Results:

187
22
0

Any other ideas?

REPOSITORY
R122 Powerdevil

REVISION DETAIL
https://phabricator.kde.org/D16918

To: anthonyfieroni, #plasma, broulik
Cc: broulik, plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

[Anthony Fieroni]

anthonyfieroni added a comment.


It looks like the problem is in dimming.

REPOSITORY
R122 Powerdevil

REVISION DETAIL
https://phabricator.kde.org/D16918

To: anthonyfieroni, #plasma, broulik, mart
Cc: broulik, plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

[Anthony Fieroni]

anthonyfieroni updated this revision to Diff 47017.
anthonyfieroni retitled this revision from "[brightnesscontrol] Do not change screen brightness on invalid values" to "[dimdisplay] Do not change screen brightness on invalid values".

REPOSITORY
R122 Powerdevil

CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D16918?vs=45566&id=47017

REVISION DETAIL
https://phabricator.kde.org/D16918

AFFECTED FILES
daemon/actions/bundled/dimdisplay.cpp

To: anthonyfieroni, #plasma, broulik, mart
Cc: thsurrel, broulik, plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

[Thomas Surrel]

thsurrel added a comment.


This bug is bothering me too and I haven't found a fix either.
I use an external screen connected to my laptop and I turn my laptop screen off by setting its brightness to 0. Then whenever I go away for a moment and the screen is turned off because energy saving kicks in, when I get back to work the laptop screen brightness gets to 100%. Particularly not nice when it's night time ...

REPOSITORY
R122 Powerdevil

REVISION DETAIL
https://phabricator.kde.org/D16918

To: anthonyfieroni, #plasma, broulik, mart
Cc: thsurrel, broulik, plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

[Anthony Fieroni]

anthonyfieroni added a comment.


@thsurrel try this patch, if it not help disable dim display from power saving configuration, is that help?

REPOSITORY
R122 Powerdevil

REVISION DETAIL
https://phabricator.kde.org/D16918

To: anthonyfieroni, #plasma, broulik, mart
Cc: thsurrel, broulik, plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart