D16901: [Folder View] implement a minimum width for icon view to ensure that labels are never rendered useless

[Nathaniel Graham]

ngraham created this revision.
ngraham added reviewers: Plasma, VDG, hein.
Herald added a project: Plasma.
Herald added a subscriber: plasma-devel.
ngraham requested review of this revision.

REVISION SUMMARY
This patch implements a minimum width when using on-the-desktop icon view to make sure that the label is never uselessly short when using very small icons.

BUG: 379432
FIXED-IN: 5.12.8

TEST PLAN
Smallest icon size, before:

Smallest icon size, after:

No change for sizes corresponding to the fourth tick on the slider and beyond

REPOSITORY
R119 Plasma Desktop

BRANCH
more-room-for-labels-with-tiny-icons (branched from Plasma/5.12)

REVISION DETAIL
https://phabricator.kde.org/D16901

AFFECTED FILES
containments/desktop/package/contents/ui/FolderView.qml

To: ngraham, #plasma, #vdg, hein
Cc: plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

[Kai Uwe Broulik]

broulik added a comment.


Can you check the `extraWidth` stuff still works? Ie. Whether left and right padding of screen is equal, since you `Math.max` the entire thing to icon size

REPOSITORY
R119 Plasma Desktop

REVISION DETAIL
https://phabricator.kde.org/D16901

To: ngraham, #plasma, #vdg, hein
Cc: broulik, plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

[Andres Betts]

abetts added a comment.


+1

REPOSITORY
R119 Plasma Desktop

REVISION DETAIL
https://phabricator.kde.org/D16901

To: ngraham, #plasma, #vdg, hein
Cc: abetts, broulik, plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, sebas, apol, mart

[Nathaniel Graham]

ngraham updated this revision to Diff 45555.
ngraham added a comment.


Make sure extraWidth stuff still works properly

REPOSITORY
R119 Plasma Desktop

CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D16901?vs=45525&id=45555

BRANCH
more-room-for-labels-with-tiny-icons (branched from Plasma/5.12)

REVISION DETAIL
https://phabricator.kde.org/D16901

AFFECTED FILES
containments/desktop/package/contents/ui/FolderView.qml

To: ngraham, #plasma, #vdg, hein
Cc: abetts, broulik, plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, sebas, apol, mart

[Nathaniel Graham]

ngraham added a comment.


Friendly ping!

REPOSITORY
R119 Plasma Desktop

REVISION DETAIL
https://phabricator.kde.org/D16901

To: ngraham, #plasma, #vdg, hein
Cc: abetts, broulik, plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, sebas, apol, mart

[Nathaniel Graham]

This revision was automatically updated to reflect the committed changes.
Closed by commit R119:0b654afd8884: [Folder View] implement a minimum width for icon view to ensure that labels are
 (authored by ngraham).

REPOSITORY
R119 Plasma Desktop

CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D16901?vs=45555&id=46487

REVISION DETAIL
https://phabricator.kde.org/D16901

AFFECTED FILES
containments/desktop/package/contents/ui/FolderView.qml

To: ngraham, #plasma, #vdg, hein
Cc: abetts, broulik, plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, sebas, apol, mart