D17402: [Device Notifier] Disable the possibility to unmount the root partition

[Thomas Surrel]

thsurrel created this revision.
thsurrel added reviewers: Plasma, VDG.
Herald added a project: Plasma.
Herald added a subscriber: plasma-devel.
thsurrel requested review of this revision.

REPOSITORY
R120 Plasma Workspace

BRANCH
arc_unmountroot (branched from master)

REVISION DETAIL
https://phabricator.kde.org/D17402

AFFECTED FILES
applets/devicenotifier/package/contents/ui/DeviceItem.qml
applets/devicenotifier/package/contents/ui/FullRepresentation.qml

To: thsurrel, #plasma, #vdg
Cc: plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

[Kai Uwe Broulik]

broulik added a comment.


I'm not very happy with all this root and home special casing all over the place (e.g. Places panel now also has something like this, etc)

REPOSITORY
R120 Plasma Workspace

REVISION DETAIL
https://phabricator.kde.org/D17402

To: thsurrel, #plasma, #vdg
Cc: broulik, plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

[Thomas Surrel]

thsurrel added a comment.


Can you develop why ? Is because of the added code ?
From a usability point of view, does it not make sense to disable something that is not possible ?

REPOSITORY
R120 Plasma Workspace

REVISION DETAIL
https://phabricator.kde.org/D17402

To: thsurrel, #plasma, #vdg
Cc: broulik, plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

[Nathaniel Graham]

ngraham added a comment.


My root and home partitions don't appear in the devices notifier (they're on an internal NVMe SSD). How do you get in this state?

REPOSITORY
R120 Plasma Workspace

REVISION DETAIL
https://phabricator.kde.org/D17402

To: thsurrel, #plasma, #vdg
Cc: ngraham, broulik, plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

[Thomas Surrel]

thsurrel added a comment.


You need to configure the plasmoid and select to show "All devices". It's showing removable devices only by default (which sounds pretty sane!).

REPOSITORY
R120 Plasma Workspace

REVISION DETAIL
https://phabricator.kde.org/D17402

To: thsurrel, #plasma, #vdg
Cc: ngraham, broulik, plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

[Nathaniel Graham]

ngraham added a comment.


Ah, I see! Lol it never even occurred to me to try to configure the plasmoid.

Given that, I think this patch makes sense. No point in allowing people to do invalid things. Should we also give the same treatment to the partition that `~` lives on, if it's different?

REPOSITORY
R120 Plasma Workspace

REVISION DETAIL
https://phabricator.kde.org/D17402

To: thsurrel, #plasma, #vdg
Cc: ngraham, broulik, plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

[Andres Betts]

abetts added a comment.


If this patch deals with the UI, is it possible to align the eject button to the middle using the progress bar as the center?

REPOSITORY
R120 Plasma Workspace

REVISION DETAIL
https://phabricator.kde.org/D17402

To: thsurrel, #plasma, #vdg
Cc: abetts, ngraham, broulik, plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, sebas, apol, mart

[Thomas Surrel]

thsurrel added a comment.


I made another patch that fixes the alignment D17420 <https://phabricator.kde.org/D17420>

REPOSITORY
R120 Plasma Workspace

REVISION DETAIL
https://phabricator.kde.org/D17402

To: thsurrel, #plasma, #vdg
Cc: abetts, ngraham, broulik, plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, sebas, apol, mart