Discussion:
D17207: Use KPasswordLineEdit
Kai Uwe Broulik
2018-11-28 08:30:54 UTC
Permalink
broulik created this revision.
broulik added reviewers: jriddell, davidedmundson.
Herald added a project: Plasma.
Herald added a subscriber: plasma-devel.
broulik requested review of this revision.

TEST PLAN
- I now get the eye button to show the password I typed
- Typing wrong password still leads to auth failure
- Typing correct password works

REPOSITORY
R121 Policykit (Polkit) KDE Agent

REVISION DETAIL
https://phabricator.kde.org/D17207

AFFECTED FILES
AuthDialog.cpp
AuthDialog.ui

To: broulik, jriddell, davidedmundson
Cc: plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart
Nathaniel Graham
2018-11-28 20:34:36 UTC
Permalink
ngraham accepted this revision.
ngraham added a comment.
This revision is now accepted and ready to land.


Works great and the code looks sane, thanks!

REPOSITORY
R121 Policykit (Polkit) KDE Agent

REVISION DETAIL
https://phabricator.kde.org/D17207

To: broulik, jriddell, davidedmundson, ngraham
Cc: ngraham, plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart
Kai Uwe Broulik
2018-11-29 08:14:35 UTC
Permalink
This revision was automatically updated to reflect the committed changes.
Closed by commit R121:a13b84e326e1: Use KPasswordLineEdit (authored by broulik).

REPOSITORY
R121 Policykit (Polkit) KDE Agent

CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D17207?vs=46378&id=46456

REVISION DETAIL
https://phabricator.kde.org/D17207

AFFECTED FILES
AuthDialog.cpp
AuthDialog.ui

To: broulik, jriddell, davidedmundson, ngraham
Cc: ngraham, plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart
Loading...