Discussion:
D16856: [comicproviderwrapper] Always finish on last request in pageRetrieved
Anthony Fieroni
2018-11-13 06:57:13 UTC
Permalink
anthonyfieroni created this revision.
anthonyfieroni added reviewers: Plasma, davidedmundson.
Herald added a project: Plasma.
Herald added a subscriber: plasma-devel.
anthonyfieroni requested review of this revision.

REVISION SUMMARY
Otherwise provider can be marked as failed

REPOSITORY
R114 Plasma Addons

REVISION DETAIL
https://phabricator.kde.org/D16856

AFFECTED FILES
dataengines/comic/comicproviderwrapper.cpp

To: anthonyfieroni, #plasma, davidedmundson
Cc: plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart
Anthony Fieroni
2018-11-16 06:53:36 UTC
Permalink
anthonyfieroni updated this revision to Diff 45556.
anthonyfieroni added a comment.


Better not change data engine

REPOSITORY
R114 Plasma Addons

CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D16856?vs=45396&id=45556

REVISION DETAIL
https://phabricator.kde.org/D16856

AFFECTED FILES
applets/comic/comic.cpp
applets/comic/comicupdater.cpp

To: anthonyfieroni, #plasma, davidedmundson
Cc: plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart
Marco Martin
2018-11-23 13:59:09 UTC
Permalink
mart added a comment.


disk syncs shouldn't be added that lightly, as they are quirte expensive, it should always relay on the event compression internal in Applet

REPOSITORY
R114 Plasma Addons

REVISION DETAIL
https://phabricator.kde.org/D16856

To: anthonyfieroni, #plasma, davidedmundson
Cc: mart, plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol
Anthony Fieroni
2018-11-25 15:06:37 UTC
Permalink
anthonyfieroni added a comment.


It's mostly one per day or accept configuration.

REPOSITORY
R114 Plasma Addons

REVISION DETAIL
https://phabricator.kde.org/D16856

To: anthonyfieroni, #plasma, davidedmundson
Cc: mart, plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol
Anthony Fieroni
2018-11-25 15:39:53 UTC
Permalink
anthonyfieroni updated this revision to Diff 46206.

REPOSITORY
R114 Plasma Addons

CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D16856?vs=45556&id=46206

REVISION DETAIL
https://phabricator.kde.org/D16856

AFFECTED FILES
applets/comic/comicupdater.cpp

To: anthonyfieroni, #plasma, davidedmundson
Cc: mart, plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol
Anthony Fieroni
2018-11-30 12:45:37 UTC
Permalink
anthonyfieroni added a comment.


Ping

REPOSITORY
R114 Plasma Addons

REVISION DETAIL
https://phabricator.kde.org/D16856

To: anthonyfieroni, #plasma, davidedmundson
Cc: mart, plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol
Loading...