D8695: Fix ampersand characters not showing in tab titles

[Corentin Risselin]

corentinr created this revision.
Restricted Application added a project: Plasma.
Restricted Application added a subscriber: plasma-devel.

REPOSITORY
R106 KSysguard

BRANCH
master

REVISION DETAIL
https://phabricator.kde.org/D8695

AFFECTED FILES
gui/Workspace.cpp

To: corentinr
Cc: plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

[Adriaan de Groot]

adridg added inline comments.

INLINE COMMENTS

Workspace.cpp:142
+ // Title ampersands must be doubled or will not be displayed and used as QT shortcut
+ insertTab(-1, sheet, dlg.sheetTitle().replace( "&", "&&" ) );
mSheetList.append( sheet );

Are you sure this won't affect tabs that *do* have shortcuts, and need them? How about after a save/restart cycle, are the ampersands re-doubled?

REPOSITORY
R106 KSysguard

REVISION DETAIL
https://phabricator.kde.org/D8695

To: corentinr
Cc: adridg, plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

[Corentin Risselin]

corentinr edited the summary of this revision.

REPOSITORY
R106 KSysguard

REVISION DETAIL
https://phabricator.kde.org/D8695

To: corentinr
Cc: adridg, plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

[Corentin Risselin]

corentinr added inline comments.

INLINE COMMENTS

adridg wrote in Workspace.cpp:142
Are you sure this won't affect tabs that *do* have shortcuts, and need them? How about after a save/restart cycle, are the ampersands re-doubled?

There is no default tab with shortcut and I felt there was no need for them. If the Qt shortcut feature is preferable the best way would probably be a tooltip upon entering an ampersand in the title.

save/restart cycle doesn't re-doubled as this replace is"on the fly" and never saved anywhere.

REPOSITORY
R106 KSysguard

REVISION DETAIL
https://phabricator.kde.org/D8695

To: corentinr
Cc: adridg, plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

[Nathaniel Graham]

ngraham added a comment.


Hello! I'm very sorry that this patch was somehow missed and not committed in back November, and that another patch with the same diff took its place yesterday. This was an oversight on our part and we will try to make sure that it doesn't happen again!

REPOSITORY
R106 KSysguard

REVISION DETAIL
https://phabricator.kde.org/D8695

To: corentinr
Cc: ngraham, adridg, plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

[David Edmundson]

davidedmundson commandeered this revision.
davidedmundson added a reviewer: corentinr.
davidedmundson added a comment.


This appears to be merged. I'm going to close it.

REPOSITORY
R106 KSysguard

REVISION DETAIL
https://phabricator.kde.org/D8695

To: davidedmundson, corentinr
Cc: davidedmundson, ngraham, adridg, plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart