Discussion:
D17440: Rotate busy indicator clockwise
Björn Feber
2018-12-08 19:33:42 UTC
Permalink
GB_2 created this revision.
GB_2 added reviewers: Breeze, VDG.
GB_2 added projects: Breeze, VDG.
Herald added a project: Plasma.
Herald added a subscriber: plasma-devel.
GB_2 requested review of this revision.

REVISION SUMMARY
Most loading/refresh icons have a circular arrow pointing clockwise, but the busy indicator is currently rotated counterclockwise. This changes it to rotate clockwise.
How most loading/refresh icons look like:
F6464496: Loading Icon Example.png <https://phabricator.kde.org/F6464496>

TEST PLAN
Use an icon theme with this kind of loading/refresh icon (such as "Papirus", "Adwaita" or "AntÌ") , open Discover and click on for example "Plasma Addons". At the bottom you can then see the busy indicator.

REPOSITORY
R858 Qt Quick Controls 2: Desktop Style

REVISION DETAIL
https://phabricator.kde.org/D17440

AFFECTED FILES
org.kde.desktop/BusyIndicator.qml

To: GB_2, #breeze, #vdg
Cc: #vdg, plasma-devel, #breeze, alexde, IohannesPetros, trickyricky26, ragreen, Pitel, crozbo, ndavis, ZrenBot, firef, skadinna, lesliezhai, ali-mohamed, jensreuterberg, aaronhoneycutt, abetts, sebas, apol, mbohlender, mart
Noah Davis
2018-12-08 20:06:00 UTC
Permalink
ndavis added a comment.


Makes sense to me. Time moves clockwise on a clock.

REPOSITORY
R858 Qt Quick Controls 2: Desktop Style

REVISION DETAIL
https://phabricator.kde.org/D17440

To: GB_2, #breeze, #vdg
Cc: ndavis, #vdg, plasma-devel, #breeze, alexde, IohannesPetros, trickyricky26, ragreen, Pitel, crozbo, ZrenBot, firef, skadinna, lesliezhai, ali-mohamed, jensreuterberg, aaronhoneycutt, abetts, sebas, apol, mbohlender, mart
Kai Uwe Broulik
2018-12-08 20:35:19 UTC
Permalink
broulik added a comment.


Did we ever have a busy indicator that rotated counter-clockwise? +1

REPOSITORY
R858 Qt Quick Controls 2: Desktop Style

REVISION DETAIL
https://phabricator.kde.org/D17440

To: GB_2, #breeze, #vdg
Cc: broulik, ndavis, #vdg, plasma-devel, #breeze, alexde, IohannesPetros, trickyricky26, ragreen, Pitel, crozbo, ZrenBot, firef, skadinna, lesliezhai, ali-mohamed, jensreuterberg, aaronhoneycutt, abetts, sebas, apol, mbohlender, mart
David Edmundson
2018-12-08 22:55:11 UTC
Permalink
davidedmundson accepted this revision.
davidedmundson added a comment.
This revision is now accepted and ready to land.


Plasma components also goes that way

REPOSITORY
R858 Qt Quick Controls 2: Desktop Style

REVISION DETAIL
https://phabricator.kde.org/D17440

To: GB_2, #breeze, #vdg, davidedmundson
Cc: davidedmundson, broulik, ndavis, #vdg, plasma-devel, #breeze, alexde, IohannesPetros, trickyricky26, ragreen, Pitel, crozbo, ZrenBot, firef, skadinna, lesliezhai, ali-mohamed, jensreuterberg, aaronhoneycutt, abetts, sebas, apol, mbohlender, mart
Loading...