D17362: [RFC] [FormLayout] Top-align item labels

[Nathaniel Graham]

ngraham created this revision.
Herald added a project: Kirigami.
Herald added a subscriber: plasma-devel.
ngraham requested review of this revision.

REVISION SUMMARY
Top-align FormLayout item labels so that they're aligned correctly for tall items. For an example of where this would be useful, see D17354 <https://phabricator.kde.org/D17354>.

This is an RFC because this code is pretty complex and I'm sure I did it wrong.

TEST PLAN
(the general mis-alignment of the labels with the text in the checkboxes is a pre-existing issue)

REPOSITORY
R169 Kirigami

BRANCH
top-aligned-left-labels (branched from master)

REVISION DETAIL
https://phabricator.kde.org/D17362

AFFECTED FILES
src/controls/FormLayout.qml

To: ngraham
Cc: plasma-devel, dkardarakos, apol, davidedmundson, mart, hein

[Nathaniel Graham]

ngraham abandoned this revision.
ngraham added a comment.


Not necessary; found a way to implement this goal in D17362 <https://phabricator.kde.org/D17362> without changes to Kirigami.

REPOSITORY
R169 Kirigami

REVISION DETAIL
https://phabricator.kde.org/D17362

To: ngraham, #kirigami, mart
Cc: plasma-devel, dkardarakos, apol, davidedmundson, mart, hein