D17203: [Task Manager] Move apps to activities from the context menu

[Thomas Surrel]

thsurrel created this revision.
thsurrel added reviewers: Plasma, hein.
Herald added a project: Plasma.
Herald added a subscriber: plasma-devel.
thsurrel requested review of this revision.

REVISION SUMMARY
The task manager context menu offers to _add_ applications to
activities, but the main use case is to _move_ an application to
another activity. This fixes the problem of having to open the
context menu twice to do this.

BUG: 401437

TEST PLAN
Right click on a application in the task manager, then select
Move To Activity and select another activity than the current one.
The application should be move right away.

REPOSITORY
R119 Plasma Desktop

BRANCH
arc_activities (branched from master)

REVISION DETAIL
https://phabricator.kde.org/D17203

AFFECTED FILES
applets/taskmanager/package/contents/ui/ContextMenu.qml

To: thsurrel, #plasma, hein
Cc: plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

[Eike Hein]

hein added a comment.


Does this mean you can't use the menu to add the window to multiple activities anymore?

REPOSITORY
R119 Plasma Desktop

REVISION DETAIL
https://phabricator.kde.org/D17203

To: thsurrel, #plasma, hein
Cc: plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

[Thomas Surrel]

thsurrel added a comment.


Yes, indeed. But it is just a proposal.
This patch mimics what is done for desktops: you can move a window to a desktop or to all of them. You lose the ability to add a window to an activity, but do we have a strong use case for that ? I personally always want to _move_ a window to another activity when I use this menu.

The alternative is to not close the context menu when we click on a activity, but I did not find how to that.

REPOSITORY
R119 Plasma Desktop

REVISION DETAIL
https://phabricator.kde.org/D17203

To: thsurrel, #plasma, hein
Cc: plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

[Eike Hein]

hein added a comment.


Well, the entire point of activities existing is that they go beyond the limitations of desktops - you can add a window to 2 out of 5 activities, not just one or all. If it's the same, we don't need both.

REPOSITORY
R119 Plasma Desktop

REVISION DETAIL
https://phabricator.kde.org/D17203

To: thsurrel, #plasma, hein
Cc: plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

[Thomas Surrel]

thsurrel abandoned this revision.
thsurrel added a comment.


I use it differently then ! :)

REPOSITORY
R119 Plasma Desktop

REVISION DETAIL
https://phabricator.kde.org/D17203

To: thsurrel, #plasma, hein
Cc: plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart