D17375: Don't automatically refresh if the user already asked apt to do so

[Aleix Pol Gonzalez]

apol created this revision.
apol added reviewers: Kubuntu, sitter, rikmills.
Herald added a project: Plasma.
Herald added a subscriber: plasma-devel.
apol requested review of this revision.

REVISION SUMMARY
Just expect apt to do the right thing.

BUG: 401810

REPOSITORY
R134 Discover Software Store

BRANCH
master

REVISION DETAIL
https://phabricator.kde.org/D17375

AFFECTED FILES
libdiscover/backends/PackageKitBackend/PackageKitNotifier.cpp

To: apol, #kubuntu, sitter, rikmills
Cc: plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

[Rik Mills]

rikmills added a comment.


Seems good to me, and a quick test on a stock Kubuntu install gets the updater registering new updates when the system does its own refresh.

REPOSITORY
R134 Discover Software Store

REVISION DETAIL
https://phabricator.kde.org/D17375

To: apol, #kubuntu, sitter, rikmills
Cc: plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

[Nathaniel Graham]

ngraham added a comment.


This helps for Kubuntu (and Neon ?) users, but what about everyone else?

REPOSITORY
R134 Discover Software Store

REVISION DETAIL
https://phabricator.kde.org/D17375

To: apol, #kubuntu, sitter, rikmills
Cc: ngraham, plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

[Rik Mills]

rikmills added a comment.

Post by Nathaniel Graham
This helps for Kubuntu (and Neon ?) users, but what about everyone else?

As the original code and this change is apt specific, for non apt distro the updater will continue as before to refresh via packagekit 5 mins after system startup, and then afterwards once every 24 hrs.

REPOSITORY
R134 Discover Software Store

REVISION DETAIL
https://phabricator.kde.org/D17375

To: apol, #kubuntu, sitter, rikmills
Cc: ngraham, plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

[Nathaniel Graham]

ngraham added a comment.


That's what I thought. Then it doesn't fully fix 401810, since people not using Kubuntu or Neon will still not have a way to change the update frequency.

REPOSITORY
R134 Discover Software Store

REVISION DETAIL
https://phabricator.kde.org/D17375

To: apol, #kubuntu, sitter, rikmills
Cc: ngraham, plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

[Rik Mills]

rikmills added a comment.

Post by Nathaniel Graham
That's what I thought. Then it doesn't fully fix 401810, since people not using Kubuntu or Neon will still not have a way to change the update frequency.

I don't think this was intended to be a full fix for that in a distro agnostic sense, though it is relevant so posted on that bug. This is specific to apt updates where currently if a x0periodic config files exists the (a) notifier and apt config prompted refreshes will at a minimum double the frequency, and (b) even worse the apt-config setting in days was being misconstrued by the notifier as **hours**, resulting in even more frequent refreshes. That is what I pointed out and discussed with Aleix a few days ago, which prompted this revision.

REPOSITORY
R134 Discover Software Store

REVISION DETAIL
https://phabricator.kde.org/D17375

To: apol, #kubuntu, sitter, rikmills
Cc: ngraham, plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

[Aleix Pol Gonzalez]

apol abandoned this revision.
apol added a comment.


It's landed, phabricator doesn't let me just close it.
https://commits.kde.org/discover/30de60f05d183e185724e614aad67b06aec987f3

REPOSITORY
R134 Discover Software Store

REVISION DETAIL
https://phabricator.kde.org/D17375

To: apol, #kubuntu, sitter, rikmills
Cc: ngraham, plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart