D17365: Round folder view delegate and label positions

[Fabian Vogt]

fvogt created this revision.
fvogt added a reviewer: Plasma.
Herald added a project: Plasma.
fvogt requested review of this revision.

REVISION SUMMARY
Currently the delegates and especially the labels can be at non-integer
positions. This results in ugly font rendering.

TEST PLAN
Before/after: https://phabricator.kde.org/F6456830

REPOSITORY
R119 Plasma Desktop

BRANCH
master

REVISION DETAIL
https://phabricator.kde.org/D17365

AFFECTED FILES
containments/desktop/package/contents/ui/FolderItemDelegate.qml
containments/desktop/package/contents/ui/FolderView.qml

To: fvogt, #plasma
Cc: plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

[Kai Uwe Broulik]

broulik added inline comments.

INLINE COMMENTS

FolderItemDelegate.qml:66
// leading to blurry rendering. The Loader is offset to account for this.
x: -main.x % 1
y: -main.y % 1

That's what this hideous code is actually supposed to do

REPOSITORY
R119 Plasma Desktop

REVISION DETAIL
https://phabricator.kde.org/D17365

To: fvogt, #plasma
Cc: broulik, plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

[Fabian Vogt]

fvogt added inline comments.

INLINE COMMENTS

broulik wrote in FolderItemDelegate.qml:66
That's what this hideous code is actually supposed to do

It doesn't work though - I'll check some more.

REPOSITORY
R119 Plasma Desktop

REVISION DETAIL
https://phabricator.kde.org/D17365

To: fvogt, #plasma
Cc: broulik, plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

[Fabian Vogt]

fvogt updated this revision to Diff 46884.
fvogt added a comment.


Turns out the label width rounding is enough

REPOSITORY
R119 Plasma Desktop

CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D17365?vs=46882&id=46884

BRANCH
master

REVISION DETAIL
https://phabricator.kde.org/D17365

AFFECTED FILES
containments/desktop/package/contents/ui/FolderItemDelegate.qml

To: fvogt, #plasma
Cc: broulik, plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

[Kai Uwe Broulik]

broulik accepted this revision.
broulik added a comment.
This revision is now accepted and ready to land.


Cool! Stable branch pls

REPOSITORY
R119 Plasma Desktop

BRANCH
master

REVISION DETAIL
https://phabricator.kde.org/D17365

To: fvogt, #plasma, broulik
Cc: broulik, plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

[Fabian Vogt]

This revision was automatically updated to reflect the committed changes.
Closed by commit R119:3526334e8234: Round label width (authored by fvogt).

REPOSITORY
R119 Plasma Desktop

CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D17365?vs=46884&id=46886

REVISION DETAIL
https://phabricator.kde.org/D17365

AFFECTED FILES
containments/desktop/package/contents/ui/FolderItemDelegate.qml

To: fvogt, #plasma, broulik
Cc: broulik, plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

[Nathaniel Graham]

ngraham added a comment.


Hmm, the "After" pictured depicts terrible kerning. Take a look at "Discover" in particular. Is this really the trade-off we're faced with? It feels like there are upstream Qt bugs here.

REPOSITORY
R119 Plasma Desktop

REVISION DETAIL
https://phabricator.kde.org/D17365

To: fvogt, #plasma, broulik
Cc: ngraham, broulik, plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

[Fabian Vogt]

fvogt added a comment.

Post by Nathaniel Graham
Hmm, the "After" pictured depicts terrible kerning. Take a look at "Discover" in particular. Is this really the trade-off we're faced with? It feels like there are upstream Qt bugs here.

Yup, definitely. Font rendering in QML has some issues.

FreeType hinting configuration and especially the used font can make a huge difference though. With "Roboto" for example it looks perfectly fine.

REPOSITORY
R119 Plasma Desktop

REVISION DETAIL
https://phabricator.kde.org/D17365

To: fvogt, #plasma, broulik
Cc: ngraham, broulik, plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart