Nathaniel Graham
2018-12-05 19:57:16 UTC
ngraham created this revision.
ngraham added reviewers: Plasma, VDG.
Herald added a project: Plasma.
Herald added a subscriber: plasma-devel.
ngraham requested review of this revision.
REVISION SUMMARY
Right now the componentchooser KCM's browser module has a really confusing setting ("In an application based on the contents of the url") that's the default. There are ancient Buzailla tickets about this being confusing, and some users report that it actually does the wrong thing for certain URLs.
This patch removes the UI for this feature and makes it a hidden fallback-only behavior for the rare case that there aren't any web browsers installed.
BUG: 100016
FIXED-IN: 5.15.0
TEST PLAN
Here's what it looks like now:
Verifications performed:
- There are no actual settings changes for any users, since browsers ask to set themselves as the default, and distros ship config files already specifying their preferred browser.
- Changing the browser in the combobox correctly updates both `~/.config/kdeglobals` and `~/.configmimeapps.list`
- The combobox's default setting is now correctly identical to what `~/.config/mimeapps.list` specifies, if anything
- KRun still does unnecessary URL introspection when there is in fact a default browser set in `~/.config/mimeapps.list` but ~/.config/kdeglobals` doesn't have a default browser set, which is fixed separately in KIO with D17371 <https://phabricator.kde.org/D17371>
REPOSITORY
R119 Plasma Desktop
BRANCH
browser-chooser-service-and-exec-only (branched from master)
REVISION DETAIL
https://phabricator.kde.org/D17372
AFFECTED FILES
kcms/componentchooser/browserconfig_ui.ui
kcms/componentchooser/componentchooserbrowser.cpp
To: ngraham, #plasma, #vdg
Cc: plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart
ngraham added reviewers: Plasma, VDG.
Herald added a project: Plasma.
Herald added a subscriber: plasma-devel.
ngraham requested review of this revision.
REVISION SUMMARY
Right now the componentchooser KCM's browser module has a really confusing setting ("In an application based on the contents of the url") that's the default. There are ancient Buzailla tickets about this being confusing, and some users report that it actually does the wrong thing for certain URLs.
This patch removes the UI for this feature and makes it a hidden fallback-only behavior for the rare case that there aren't any web browsers installed.
BUG: 100016
FIXED-IN: 5.15.0
TEST PLAN
Here's what it looks like now:
Verifications performed:
- There are no actual settings changes for any users, since browsers ask to set themselves as the default, and distros ship config files already specifying their preferred browser.
- Changing the browser in the combobox correctly updates both `~/.config/kdeglobals` and `~/.configmimeapps.list`
- The combobox's default setting is now correctly identical to what `~/.config/mimeapps.list` specifies, if anything
- KRun still does unnecessary URL introspection when there is in fact a default browser set in `~/.config/mimeapps.list` but ~/.config/kdeglobals` doesn't have a default browser set, which is fixed separately in KIO with D17371 <https://phabricator.kde.org/D17371>
REPOSITORY
R119 Plasma Desktop
BRANCH
browser-chooser-service-and-exec-only (branched from master)
REVISION DETAIL
https://phabricator.kde.org/D17372
AFFECTED FILES
kcms/componentchooser/browserconfig_ui.ui
kcms/componentchooser/componentchooserbrowser.cpp
To: ngraham, #plasma, #vdg
Cc: plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart