D17354: [Digital clock plasmoid] Calendar settings page: port to QQC2 & Kirigami and improve layout

[Nathaniel Graham]

ngraham created this revision.
ngraham added reviewers: Plasma, VDG, mart.
Herald added a project: Plasma.
Herald added a subscriber: plasma-devel.
ngraham requested review of this revision.

REVISION SUMMARY
BUG: 400663
FIXED-IN: 5.15.0

TEST PLAN
Before:

After:

Everything still works.

REPOSITORY
R120 Plasma Workspace

BRANCH
improve-calendar-settings-layout (branched from master)

REVISION DETAIL
https://phabricator.kde.org/D17354

AFFECTED FILES
applets/digital-clock/package/contents/ui/configCalendar.qml

To: ngraham, #plasma, #vdg, mart
Cc: plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

[Nathaniel Graham]

ngraham updated this revision to Diff 46855.
ngraham added a comment.


Make sure it's centered

REPOSITORY
R120 Plasma Workspace

CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D17354?vs=46854&id=46855

BRANCH
improve-calendar-settings-layout (branched from master)

REVISION DETAIL
https://phabricator.kde.org/D17354

AFFECTED FILES
applets/digital-clock/package/contents/ui/configCalendar.qml

To: ngraham, #plasma, #vdg, mart
Cc: plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

[Vlad Zagorodniy]

zzag added a comment.


Just wondering, shouldn't it look like

Available plugins: [ ] Astronomical events
[ ] Holidays

?

REPOSITORY
R120 Plasma Workspace

REVISION DETAIL
https://phabricator.kde.org/D17354

To: ngraham, #plasma, #vdg, mart
Cc: zzag, plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

[Nathaniel Graham]

ngraham added a comment.

Post by Vlad Zagorodniy
Just wondering, shouldn't it look like
Available plugins: [ ] Astronomical events
[ ] Holidays
?

That was my first thought too, but this whole list of checkboxes/plugins is dynamic, so putting the label on the left for the first item is a bit challenging.

Though maybe this reveals that we should be using a list box instead of a dynamic set of checkboxes.

REPOSITORY
R120 Plasma Workspace

REVISION DETAIL
https://phabricator.kde.org/D17354

To: ngraham, #plasma, #vdg, mart
Cc: zzag, plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

[Andres Betts]

abetts added a comment.


Would you want to move the General section to the top and plugins second?

In general, general labels maybe belong to the very top of a KCM? To me, it seems like a more logical progression. From all items to more specific items.

REPOSITORY
R120 Plasma Workspace

REVISION DETAIL
https://phabricator.kde.org/D17354

To: ngraham, #plasma, #vdg, mart
Cc: abetts, zzag, plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, sebas, apol, mart

[Michail Vourlakos]

mvourlakos added a comment.

Post by Nathaniel Graham

Post by Vlad Zagorodniy
Just wondering, shouldn't it look like
Available plugins: [ ] Astronomical events
[ ] Holidays
?

That was my first thought too, but this whole list of checkboxes/plugins is dynamic, so putting the label on the left for the first item is a bit challenging.
Though maybe this reveals that we should be using a list box instead of a dynamic set of checkboxes.

It should be possible, how about adding "Available Plugins" in an item that has the exacth same height with the QtControls.CheckBox ?
at least this was one of the tricks I used for: Loading Image...

REPOSITORY
R120 Plasma Workspace

REVISION DETAIL
https://phabricator.kde.org/D17354

To: ngraham, #plasma, #vdg, mart
Cc: mvourlakos, abetts, zzag, plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, sebas, apol, mart

[Nathaniel Graham]

ngraham added a comment.


OK, if I give the ColumnLayout a label, it mostly works, but the label is vertically centered rather than being top-aligned:

F6455150: Needs to be top-aligned.png <https://phabricator.kde.org/F6455150>

REPOSITORY
R120 Plasma Workspace

REVISION DETAIL
https://phabricator.kde.org/D17354

To: ngraham, #plasma, #vdg, mart
Cc: mvourlakos, abetts, zzag, plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, sebas, apol, mart

[Nathaniel Graham]

ngraham updated this revision to Diff 46872.
ngraham added a comment.


- Move General section back to the top, where it belongs
- Use a left label for the plugin section (currently bugged pending a Kirigami ptch: D17362 <https://phabricator.kde.org/D17362>)

REPOSITORY
R120 Plasma Workspace

CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D17354?vs=46855&id=46872

BRANCH
improve-calendar-settings-layout (branched from master)

REVISION DETAIL
https://phabricator.kde.org/D17354

AFFECTED FILES
applets/digital-clock/package/contents/ui/configCalendar.qml

To: ngraham, #plasma, #vdg, mart
Cc: mvourlakos, abetts, zzag, plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, sebas, apol, mart

[Andres Betts]

abetts added a comment.


Thank you!

REPOSITORY
R120 Plasma Workspace

REVISION DETAIL
https://phabricator.kde.org/D17354

To: ngraham, #plasma, #vdg, mart
Cc: mvourlakos, abetts, zzag, plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, sebas, apol, mart

[Nathaniel Graham]

ngraham updated this revision to Diff 46967.
ngraham added a comment.


Align the label to the first child properly

REPOSITORY
R120 Plasma Workspace

CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D17354?vs=46872&id=46967

BRANCH
improve-calendar-settings-layout (branched from master)

REVISION DETAIL
https://phabricator.kde.org/D17354

AFFECTED FILES
applets/digital-clock/package/contents/ui/configCalendar.qml

To: ngraham, #plasma, #vdg, mart
Cc: mvourlakos, abetts, zzag, plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, sebas, apol, mart

[Alex Debus]

alexde added a comment.


Thank you Nate! I am just curious if you considered to structure titles and options vertically, where the options are indeted by a tab:

General

[ ] Show week number

Available plugins

[ ] Plugin A
[ ] Plugin B

That's would I personally would favor.

Kind Regards

REPOSITORY
R120 Plasma Workspace

BRANCH
improve-calendar-settings-layout (branched from master)

REVISION DETAIL
https://phabricator.kde.org/D17354

To: ngraham, #plasma, #vdg, mart, davidedmundson
Cc: alexde, mvourlakos, abetts, zzag, plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, sebas, apol, mart

[Nathaniel Graham]

ngraham added a comment.
Yes, quite a bit. This current layout style is the result of an //enormous// amount of internal discussion. There is no one style that pleased everyone, but this is the one that was most popular and generally considered the most attractive and pleasant to use overall. Again, you can't please everybody especially in matters of style and design, but this style seemed overall to be the favorite when we were trying to figure what we should standardize on.

Changing the style just here would introduce inconsistency at a time when we're trying to make everything more consistent. The current FormLayout style is what we've decided on for the moment and I think it makes sense to fully implement it before we think about replacing it with something else. :)

REPOSITORY
R120 Plasma Workspace

BRANCH
improve-calendar-settings-layout (branched from master)

REVISION DETAIL
https://phabricator.kde.org/D17354

To: ngraham, #plasma, #vdg, mart, davidedmundson
Cc: alexde, mvourlakos, abetts, zzag, plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, sebas, apol, mart

[Nathaniel Graham]

This revision was automatically updated to reflect the committed changes.
Closed by commit R120:ad34212a8ccd: [Digital clock plasmoid] Calendar settings page: port to QQC2 &amp; Kirigami and
 (authored by ngraham).

REPOSITORY
R120 Plasma Workspace

CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D17354?vs=46967&id=46992

REVISION DETAIL
https://phabricator.kde.org/D17354

AFFECTED FILES
applets/digital-clock/package/contents/ui/configCalendar.qml

To: ngraham, #plasma, #vdg, mart, davidedmundson
Cc: alexde, mvourlakos, abetts, zzag, plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, sebas, apol, mart

[Alex Debus]

alexde added a comment.

Post by Nathaniel Graham
Changing the style just here would introduce inconsistency at a time when we're trying to make everything more consistent. The current FormLayout style is what we've decided on for the moment and I think it makes sense to fully implement it before we think about replacing it with something else. :)

Sounds reasonable to me! ;) Can you please point me to the discussion? Thanks!

REPOSITORY
R120 Plasma Workspace

REVISION DETAIL
https://phabricator.kde.org/D17354

To: ngraham, #plasma, #vdg, mart, davidedmundson
Cc: alexde, mvourlakos, abetts, zzag, plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, sebas, apol, mart