D17394: [Device Notifier] Fix transition animation

[Thomas Surrel]

thsurrel created this revision.
thsurrel added reviewers: Plasma, VDG.
Herald added a project: Plasma.
Herald added a subscriber: plasma-devel.
thsurrel requested review of this revision.

REVISION SUMMARY
In the specific case of having the device notifier opened
and inserting a device that has been configured to be
automatically mounted, the transition animation could be
interrupted resulting in the opacity being wrong.

TEST PLAN
In the setup discribed in the summary, you should never
see something like the attached screenshot where the list
of action opacity is not 1.

See http://doc.qt.io/qt-5/qml-qtquick-viewtransition.html#handling-interrupted-animations
for more information.

REPOSITORY
R120 Plasma Workspace

BRANCH
arc_transitions (branched from master)

REVISION DETAIL
https://phabricator.kde.org/D17394

AFFECTED FILES
applets/devicenotifier/package/contents/ui/DeviceItem.qml

To: thsurrel, #plasma, #vdg
Cc: plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

[Nathaniel Graham]

ngraham accepted this revision.
ngraham added a comment.
This revision is now accepted and ready to land.


Nice catch! This works and looks good to me, but let's make sure the #plasma <https://phabricator.kde.org/tag/plasma/> folks agree. :)

REPOSITORY
R120 Plasma Workspace

BRANCH
arc_transitions (branched from master)

REVISION DETAIL
https://phabricator.kde.org/D17394

To: thsurrel, #plasma, #vdg, ngraham
Cc: ngraham, plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

[David Edmundson]

davidedmundson added inline comments.

INLINE COMMENTS

DeviceItem.qml:197
NumberAnimation {
property: "opacity"
from: 0

alwaysRunToEnd : true

REPOSITORY
R120 Plasma Workspace

BRANCH
arc_transitions (branched from master)

REVISION DETAIL
https://phabricator.kde.org/D17394

To: thsurrel, #plasma, #vdg, ngraham
Cc: davidedmundson, ngraham, plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

[Kai Uwe Broulik]

broulik added a comment.


Is this Bug 379759?

REPOSITORY
R120 Plasma Workspace

BRANCH
arc_transitions (branched from master)

REVISION DETAIL
https://phabricator.kde.org/D17394

To: thsurrel, #plasma, #vdg, ngraham
Cc: broulik, davidedmundson, ngraham, plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

[Thomas Surrel]

thsurrel added inline comments.

INLINE COMMENTS

davidedmundson wrote in DeviceItem.qml:197
alwaysRunToEnd : true

That does not work by itself.

REPOSITORY
R120 Plasma Workspace

BRANCH
arc_transitions (branched from master)

REVISION DETAIL
https://phabricator.kde.org/D17394

To: thsurrel, #plasma, #vdg, ngraham
Cc: broulik, davidedmundson, ngraham, plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

[Thomas Surrel]

thsurrel added a comment.

Post by Kai Uwe Broulik
Is this Bug 379759?

I don't think so, but I will have a look at that one too.

If any of you guys can have a look at my other device notifier patches, that would be really nice!
D16170 <https://phabricator.kde.org/D16170>
D16212 <https://phabricator.kde.org/D16212>
D17127 <https://phabricator.kde.org/D17127>

REPOSITORY
R120 Plasma Workspace

BRANCH
arc_transitions (branched from master)

REVISION DETAIL
https://phabricator.kde.org/D17394

To: thsurrel, #plasma, #vdg, ngraham, davidedmundson
Cc: broulik, davidedmundson, ngraham, plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

[Thomas Surrel]

This revision was automatically updated to reflect the committed changes.
Closed by commit R120:ab47422c1b41: [Device Notifier] Fix transition animation (authored by thsurrel).

REPOSITORY
R120 Plasma Workspace

CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D17394?vs=47001&id=47023

REVISION DETAIL
https://phabricator.kde.org/D17394

AFFECTED FILES
applets/devicenotifier/package/contents/ui/DeviceItem.qml

To: thsurrel, #plasma, #vdg, ngraham, davidedmundson
Cc: broulik, davidedmundson, ngraham, plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart