D17323: Panel edit mode: change screen edge button hover cursor, add icons to screen edge button and panel size button

[Björn Feber]

GB_2 created this revision.
GB_2 added reviewers: Plasma, VDG.
GB_2 added projects: Plasma, VDG.
Herald added a subscriber: plasma-devel.
GB_2 requested review of this revision.

REVISION SUMMARY
Modifies the screen edge button and panel size button in the panel edit mode to make them easier to understand and look better (as suggested in this Phabricator task: https://phabricator.kde.org/T10047):

- When you hover over the screen edge button it now shows a move cursor (SizeAllCursor)
- The screen edge button now has an icon (transform-move)
- The panel size button now has an icon (zoom-fit-width/zoom-fit-height)

F6451696: Panel Edit Mode Buttons.png <https://phabricator.kde.org/F6451696>

TEST PLAN
Open the panel edit mode.

REPOSITORY
R119 Plasma Desktop

REVISION DETAIL
https://phabricator.kde.org/D17323

AFFECTED FILES
desktoppackage/contents/configuration/panelconfiguration/EdgeHandle.qml
desktoppackage/contents/configuration/panelconfiguration/SizeHandle.qml

To: GB_2, #plasma, #vdg
Cc: #vdg, plasma-devel, #plasma, alexde, IohannesPetros, trickyricky26, ragreen, Pitel, crozbo, ndavis, ZrenBot, firef, skadinna, lesliezhai, ali-mohamed, jensreuterberg, aaronhoneycutt, abetts, sebas, apol, mbohlender, mart

[TrickyRicky]

trickyricky26 added a comment.


This is awesome, thank you!

If this is not clear enough, would it be technically possible to display a tooltip explaining you have to drag the button and make that tooltip appear when the user clicks on the button without dragging it?

REPOSITORY
R119 Plasma Desktop

REVISION DETAIL
https://phabricator.kde.org/D17323

To: GB_2, #plasma, #vdg
Cc: trickyricky26, #vdg, plasma-devel, #plasma, alexde, IohannesPetros, ragreen, Pitel, crozbo, ndavis, ZrenBot, firef, skadinna, lesliezhai, ali-mohamed, jensreuterberg, aaronhoneycutt, abetts, sebas, apol, mbohlender, mart

[Nathaniel Graham]

ngraham added a comment.


Nice!

While we're at it, what do you think about adding a tooltip saying "Drag to the screen edge where you would like this panel to love" or something?

REPOSITORY
R119 Plasma Desktop

REVISION DETAIL
https://phabricator.kde.org/D17323

To: GB_2, #plasma, #vdg
Cc: ngraham, trickyricky26, #vdg, plasma-devel, #plasma, alexde, IohannesPetros, ragreen, Pitel, crozbo, ndavis, ZrenBot, firef, skadinna, lesliezhai, ali-mohamed, jensreuterberg, aaronhoneycutt, abetts, sebas, apol, mbohlender, mart

[Björn Feber]

GB_2 added a comment.

Post by TrickyRicky
This is awesome, thank you!
If this is not clear enough, would it be technically possible to display a tooltip explaining you have to drag the button and make that tooltip appear when the user clicks on the button without dragging it?
Nice!
While we're at it, what do you think about adding a tooltip saying "Drag to the screen edge where you would like this panel to love" or something?

Ok, I will add that!

REPOSITORY
R119 Plasma Desktop

REVISION DETAIL
https://phabricator.kde.org/D17323

To: GB_2, #plasma, #vdg
Cc: ngraham, trickyricky26, #vdg, plasma-devel, #plasma, alexde, IohannesPetros, ragreen, Pitel, crozbo, ndavis, ZrenBot, firef, skadinna, lesliezhai, ali-mohamed, jensreuterberg, aaronhoneycutt, abetts, sebas, apol, mbohlender, mart

[Nathaniel Graham]

ngraham added a comment.


Feel free to come up with a better wording; mine is probably crap since I just randomly thought of it. :p

REPOSITORY
R119 Plasma Desktop

REVISION DETAIL
https://phabricator.kde.org/D17323

To: GB_2, #plasma, #vdg
Cc: ngraham, trickyricky26, #vdg, plasma-devel, #plasma, alexde, IohannesPetros, ragreen, Pitel, crozbo, ndavis, ZrenBot, firef, skadinna, lesliezhai, ali-mohamed, jensreuterberg, aaronhoneycutt, abetts, sebas, apol, mbohlender, mart

[Björn Feber]

GB_2 added a comment.

Post by Nathaniel Graham
Feel free to come up with a better wording; mine is probably crap since I just randomly thought of it. :p

Yeah :P

REPOSITORY
R119 Plasma Desktop

REVISION DETAIL
https://phabricator.kde.org/D17323

To: GB_2, #plasma, #vdg
Cc: ngraham, trickyricky26, #vdg, plasma-devel, #plasma, alexde, IohannesPetros, ragreen, Pitel, crozbo, ndavis, ZrenBot, firef, skadinna, lesliezhai, ali-mohamed, jensreuterberg, aaronhoneycutt, abetts, sebas, apol, mbohlender, mart

[Matheus Marinho]

matheusm added a comment.


+1, but why aren't the buttons content centered?

REPOSITORY
R119 Plasma Desktop

REVISION DETAIL
https://phabricator.kde.org/D17323

To: GB_2, #plasma, #vdg
Cc: matheusm, ngraham, trickyricky26, #vdg, plasma-devel, #plasma, alexde, IohannesPetros, ragreen, Pitel, crozbo, ndavis, ZrenBot, firef, skadinna, lesliezhai, ali-mohamed, jensreuterberg, aaronhoneycutt, abetts, sebas, apol, mbohlender, mart

[Björn Feber]

GB_2 added a comment.

Post by Matheus Marinho
+1, but why aren't the buttons content centered?

They are, do you think that because of the screenshot?

REPOSITORY
R119 Plasma Desktop

REVISION DETAIL
https://phabricator.kde.org/D17323

To: GB_2, #plasma, #vdg
Cc: matheusm, ngraham, trickyricky26, #vdg, plasma-devel, #plasma, alexde, IohannesPetros, ragreen, Pitel, crozbo, ndavis, ZrenBot, firef, skadinna, lesliezhai, ali-mohamed, jensreuterberg, aaronhoneycutt, abetts, sebas, apol, mbohlender, mart

[Björn Feber]

GB_2 updated this revision to Diff 46749.
GB_2 edited the summary of this revision.
GB_2 added a comment.


Update panel size button icons.

REPOSITORY
R119 Plasma Desktop

CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D17323?vs=46741&id=46749

REVISION DETAIL
https://phabricator.kde.org/D17323

AFFECTED FILES
desktoppackage/contents/configuration/panelconfiguration/EdgeHandle.qml
desktoppackage/contents/configuration/panelconfiguration/SizeHandle.qml

To: GB_2, #plasma, #vdg
Cc: matheusm, ngraham, trickyricky26, #vdg, plasma-devel, #plasma, alexde, IohannesPetros, ragreen, Pitel, crozbo, ndavis, ZrenBot, firef, skadinna, lesliezhai, ali-mohamed, jensreuterberg, aaronhoneycutt, abetts, sebas, apol, mbohlender, mart

[Matheus Marinho]

matheusm added a comment.

Post by Björn Feber

Post by Matheus Marinho
+1, but why aren't the buttons content centered?

They are, do you think that because of the screenshot?

Looks like so...

REPOSITORY
R119 Plasma Desktop

REVISION DETAIL
https://phabricator.kde.org/D17323

To: GB_2, #plasma, #vdg
Cc: matheusm, ngraham, trickyricky26, #vdg, plasma-devel, #plasma, alexde, IohannesPetros, ragreen, Pitel, crozbo, ndavis, ZrenBot, firef, skadinna, lesliezhai, ali-mohamed, jensreuterberg, aaronhoneycutt, abetts, sebas, apol, mbohlender, mart

[Björn Feber]

GB_2 added a comment.


Oh, you mean the button content...
I will try to fix that!

REPOSITORY
R119 Plasma Desktop

REVISION DETAIL
https://phabricator.kde.org/D17323

To: GB_2, #plasma, #vdg
Cc: matheusm, ngraham, trickyricky26, #vdg, plasma-devel, #plasma, alexde, IohannesPetros, ragreen, Pitel, crozbo, ndavis, ZrenBot, firef, skadinna, lesliezhai, ali-mohamed, jensreuterberg, aaronhoneycutt, abetts, sebas, apol, mbohlender, mart

[Björn Feber]

GB_2 added a comment.


Hmm... when a button has an icon the content gets aligned on the left and I can't find a way to change it...

REPOSITORY
R119 Plasma Desktop

REVISION DETAIL
https://phabricator.kde.org/D17323

To: GB_2, #plasma, #vdg
Cc: matheusm, ngraham, trickyricky26, #vdg, plasma-devel, #plasma, alexde, IohannesPetros, ragreen, Pitel, crozbo, ndavis, ZrenBot, firef, skadinna, lesliezhai, ali-mohamed, jensreuterberg, aaronhoneycutt, abetts, sebas, apol, mbohlender, mart

[Björn Feber]

GB_2 added a comment.


I managed to fix it, but it the Plasma QML Button code needs to be changed. Should I create a new Phabricator revision or add it here?

REPOSITORY
R119 Plasma Desktop

REVISION DETAIL
https://phabricator.kde.org/D17323

To: GB_2, #plasma, #vdg
Cc: matheusm, ngraham, trickyricky26, #vdg, plasma-devel, #plasma, alexde, IohannesPetros, ragreen, Pitel, crozbo, ndavis, ZrenBot, firef, skadinna, lesliezhai, ali-mohamed, jensreuterberg, aaronhoneycutt, abetts, sebas, apol, mbohlender, mart

[Nathaniel Graham]

ngraham added a comment.


Another revision, please. Thanks for all the great fixes here!

REPOSITORY
R119 Plasma Desktop

REVISION DETAIL
https://phabricator.kde.org/D17323

To: GB_2, #plasma, #vdg
Cc: matheusm, ngraham, trickyricky26, #vdg, plasma-devel, #plasma, alexde, IohannesPetros, ragreen, Pitel, crozbo, ndavis, ZrenBot, firef, skadinna, lesliezhai, ali-mohamed, jensreuterberg, aaronhoneycutt, abetts, sebas, apol, mbohlender, mart

[Björn Feber]

GB_2 added a comment.


Waiting for https://phabricator.kde.org/D17355

REPOSITORY
R119 Plasma Desktop

REVISION DETAIL
https://phabricator.kde.org/D17323

To: GB_2, #plasma, #vdg
Cc: matheusm, ngraham, trickyricky26, #vdg, plasma-devel, #plasma, alexde, IohannesPetros, ragreen, Pitel, crozbo, ndavis, ZrenBot, firef, skadinna, lesliezhai, ali-mohamed, jensreuterberg, aaronhoneycutt, abetts, sebas, apol, mbohlender, mart

[Nathaniel Graham]

ngraham added a comment.


Did we decide not to move forward with the idea of a tooltip, or is that being done in another patch?

REPOSITORY
R119 Plasma Desktop

REVISION DETAIL
https://phabricator.kde.org/D17323

To: GB_2, #plasma, #vdg
Cc: matheusm, ngraham, trickyricky26, #vdg, plasma-devel, #plasma, alexde, IohannesPetros, ragreen, Pitel, crozbo, ndavis, ZrenBot, firef, skadinna, lesliezhai, ali-mohamed, jensreuterberg, aaronhoneycutt, abetts, sebas, apol, mbohlender, mart

[Björn Feber]

GB_2 added a comment.


Because https://phabricator.kde.org/D17355 is currently not working properly, we have two options:

1. Small "Height/Width" button

F6458263: Panel Edit Mode Buttons (1).png <https://phabricator.kde.org/F6458263>

2. Align "Height/Width" button contents on the left side

F6458265: Panel Edit Mode Buttons (2).png <https://phabricator.kde.org/F6458265>

And yes, I will still add the tooltip.

REPOSITORY
R119 Plasma Desktop

REVISION DETAIL
https://phabricator.kde.org/D17323

To: GB_2, #plasma, #vdg
Cc: matheusm, ngraham, trickyricky26, #vdg, plasma-devel, #plasma, alexde, IohannesPetros, ragreen, Pitel, crozbo, ndavis, ZrenBot, firef, skadinna, lesliezhai, ali-mohamed, jensreuterberg, aaronhoneycutt, abetts, sebas, apol, mbohlender, mart

[Nathaniel Graham]

ngraham added a comment.

2. Align "Height/Width" button contents on the left side F6458265: Panel Edit Mode Buttons (2).png <https://phabricator.kde.org/F6458265>

This is the choice that basically just uses the button's default appearance rather than locally overriding anything, right? If so, I would prefer this approach. Local workarounds for toolkit bugs are almost never worth it when you own and control the toolkit IMHO.

REPOSITORY
R119 Plasma Desktop

REVISION DETAIL
https://phabricator.kde.org/D17323

To: GB_2, #plasma, #vdg
Cc: matheusm, ngraham, trickyricky26, #vdg, plasma-devel, #plasma, alexde, IohannesPetros, ragreen, Pitel, crozbo, ndavis, ZrenBot, firef, skadinna, lesliezhai, ali-mohamed, jensreuterberg, aaronhoneycutt, abetts, sebas, apol, mbohlender, mart

[Björn Feber]

GB_2 added a comment.


Ok, number two then.

REPOSITORY
R119 Plasma Desktop

REVISION DETAIL
https://phabricator.kde.org/D17323

To: GB_2, #plasma, #vdg
Cc: matheusm, ngraham, trickyricky26, #vdg, plasma-devel, #plasma, alexde, IohannesPetros, ragreen, Pitel, crozbo, ndavis, ZrenBot, firef, skadinna, lesliezhai, ali-mohamed, jensreuterberg, aaronhoneycutt, abetts, sebas, apol, mbohlender, mart

[David Edmundson]

davidedmundson added a comment.

Local workarounds for toolkit bugs are ..

I fully 100% agree on that principle, but in this specific case from my tech POV, option 1 is fine too.

Sizing items is typically in the jurisdiction of the app using the component rather than the component itself - as long as you stay above the minimum size hints from the component.
This patch would, it's akin to doing QWidget::setHorizontalSizePolicy(Minimum)

I don't have an opinion on which is better UI.

REPOSITORY
R119 Plasma Desktop

REVISION DETAIL
https://phabricator.kde.org/D17323

To: GB_2, #plasma, #vdg
Cc: davidedmundson, matheusm, ngraham, trickyricky26, #vdg, plasma-devel, #plasma, alexde, IohannesPetros, ragreen, Pitel, crozbo, ndavis, ZrenBot, firef, skadinna, lesliezhai, ali-mohamed, jensreuterberg, aaronhoneycutt, abetts, sebas, apol, mbohlender, mart

[Björn Feber]

GB_2 updated this revision to Diff 46971.
GB_2 added a comment.


Added the tooltip.
F6459564: Panel Edit Mode Buttons (3).png <https://phabricator.kde.org/F6459564>
It is ready now!

REPOSITORY
R119 Plasma Desktop

CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D17323?vs=46749&id=46971

REVISION DETAIL
https://phabricator.kde.org/D17323

AFFECTED FILES
desktoppackage/contents/configuration/panelconfiguration/EdgeHandle.qml
desktoppackage/contents/configuration/panelconfiguration/SizeHandle.qml

To: GB_2, #plasma, #vdg
Cc: davidedmundson, matheusm, ngraham, trickyricky26, #vdg, plasma-devel, #plasma, alexde, IohannesPetros, ragreen, Pitel, crozbo, ndavis, ZrenBot, firef, skadinna, lesliezhai, ali-mohamed, jensreuterberg, aaronhoneycutt, abetts, sebas, apol, mbohlender, mart

[Nathaniel Graham]

ngraham added a comment.


Hmm, that tooltip doesn't match the style. Why not use the QQC2 tooltip?

REPOSITORY
R119 Plasma Desktop

REVISION DETAIL
https://phabricator.kde.org/D17323

To: GB_2, #plasma, #vdg
Cc: davidedmundson, matheusm, ngraham, trickyricky26, #vdg, plasma-devel, #plasma, alexde, IohannesPetros, ragreen, Pitel, crozbo, ndavis, ZrenBot, firef, skadinna, lesliezhai, ali-mohamed, jensreuterberg, aaronhoneycutt, abetts, sebas, apol, mbohlender, mart

[Björn Feber]

GB_2 updated this revision to Diff 46972.
GB_2 added a comment.


Use QQC2 tooltip.

REPOSITORY
R119 Plasma Desktop

CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D17323?vs=46971&id=46972

REVISION DETAIL
https://phabricator.kde.org/D17323

AFFECTED FILES
desktoppackage/contents/configuration/panelconfiguration/EdgeHandle.qml
desktoppackage/contents/configuration/panelconfiguration/SizeHandle.qml

To: GB_2, #plasma, #vdg
Cc: davidedmundson, matheusm, ngraham, trickyricky26, #vdg, plasma-devel, #plasma, alexde, IohannesPetros, ragreen, Pitel, crozbo, ndavis, ZrenBot, firef, skadinna, lesliezhai, ali-mohamed, jensreuterberg, aaronhoneycutt, abetts, sebas, apol, mbohlender, mart

[Björn Feber]

GB_2 added a comment.


Oops, forgot the import...

REPOSITORY
R119 Plasma Desktop

REVISION DETAIL
https://phabricator.kde.org/D17323

To: GB_2, #plasma, #vdg
Cc: davidedmundson, matheusm, ngraham, trickyricky26, #vdg, plasma-devel, #plasma, alexde, IohannesPetros, ragreen, Pitel, crozbo, ndavis, ZrenBot, firef, skadinna, lesliezhai, ali-mohamed, jensreuterberg, aaronhoneycutt, abetts, sebas, apol, mbohlender, mart

[Björn Feber]

GB_2 updated this revision to Diff 46973.
GB_2 added a comment.


Add import.

REPOSITORY
R119 Plasma Desktop

CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D17323?vs=46972&id=46973

REVISION DETAIL
https://phabricator.kde.org/D17323

AFFECTED FILES
desktoppackage/contents/configuration/panelconfiguration/EdgeHandle.qml
desktoppackage/contents/configuration/panelconfiguration/SizeHandle.qml

To: GB_2, #plasma, #vdg
Cc: davidedmundson, matheusm, ngraham, trickyricky26, #vdg, plasma-devel, #plasma, alexde, IohannesPetros, ragreen, Pitel, crozbo, ndavis, ZrenBot, firef, skadinna, lesliezhai, ali-mohamed, jensreuterberg, aaronhoneycutt, abetts, sebas, apol, mbohlender, mart

[TrickyRicky]

trickyricky26 added a comment.


Will that tooltip be shown when just clicking on the button without dragging?

It would be very helpful to trigger the tooltip when the button is pressed, but not dragged.

REPOSITORY
R119 Plasma Desktop

REVISION DETAIL
https://phabricator.kde.org/D17323

To: GB_2, #plasma, #vdg
Cc: davidedmundson, matheusm, ngraham, trickyricky26, #vdg, plasma-devel, #plasma, alexde, IohannesPetros, ragreen, Pitel, crozbo, ndavis, ZrenBot, firef, skadinna, lesliezhai, ali-mohamed, jensreuterberg, aaronhoneycutt, abetts, sebas, apol, mbohlender, mart

[Nathaniel Graham]

ngraham added a comment.


We're getting there!

Right now, the tooltip appears if I click-and-hold for a moment, but not when I just click. Since that's the use case we're targeting, we should probably make it appear for click-and-quickly-release as well.

INLINE COMMENTS

EdgeHandle.qml:36
+ visible: false
+ height: panel.location == PlasmaCore.Types.TopEdge || panel.location == PlasmaCore.Types.BottomEdge ? 40 : 60
+ width: panel.location == PlasmaCore.Types.TopEdge || panel.location == PlasmaCore.Types.BottomEdge ? 190 : 130

Hardcoding heights and widths like this strikes me as likely to break for translated text, which could be much longer or shorter.

EdgeHandle.qml:39
+ x: parent.width / 2 - width / 2
+ y: panel.location == PlasmaCore.Types.TopEdge || panel.location == PlasmaCore.Types.BottomEdge ? 32 : -62
+ contentItem: PlasmaComponents.Label {

Like the widths and heights above, these magic numbers seem fragile. It's probably better to position using anchors rather than `x` and `y` values like this.

REPOSITORY
R119 Plasma Desktop

REVISION DETAIL
https://phabricator.kde.org/D17323

To: GB_2, #plasma, #vdg
Cc: davidedmundson, matheusm, ngraham, trickyricky26, #vdg, plasma-devel, #plasma, alexde, IohannesPetros, ragreen, Pitel, crozbo, ndavis, ZrenBot, firef, skadinna, lesliezhai, ali-mohamed, jensreuterberg, aaronhoneycutt, abetts, sebas, apol, mbohlender, mart

[Björn Feber]

GB_2 updated this revision to Diff 47010.
GB_2 added a comment.


Improve code and add tooltip timeout.

REPOSITORY
R119 Plasma Desktop

CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D17323?vs=46973&id=47010

REVISION DETAIL
https://phabricator.kde.org/D17323

AFFECTED FILES
desktoppackage/contents/configuration/panelconfiguration/EdgeHandle.qml
desktoppackage/contents/configuration/panelconfiguration/SizeHandle.qml

To: GB_2, #plasma, #vdg
Cc: davidedmundson, matheusm, ngraham, trickyricky26, #vdg, plasma-devel, #plasma, alexde, IohannesPetros, ragreen, Pitel, crozbo, ndavis, ZrenBot, firef, skadinna, lesliezhai, ali-mohamed, jensreuterberg, aaronhoneycutt, abetts, sebas, apol, mbohlender, mart

[Björn Feber]

GB_2 updated this revision to Diff 47011.
GB_2 added a comment.


Increase tooltip timeout.

REPOSITORY
R119 Plasma Desktop

CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D17323?vs=47010&id=47011

REVISION DETAIL
https://phabricator.kde.org/D17323

AFFECTED FILES
desktoppackage/contents/configuration/panelconfiguration/EdgeHandle.qml
desktoppackage/contents/configuration/panelconfiguration/SizeHandle.qml

To: GB_2, #plasma, #vdg
Cc: davidedmundson, matheusm, ngraham, trickyricky26, #vdg, plasma-devel, #plasma, alexde, IohannesPetros, ragreen, Pitel, crozbo, ndavis, ZrenBot, firef, skadinna, lesliezhai, ali-mohamed, jensreuterberg, aaronhoneycutt, abetts, sebas, apol, mbohlender, mart

[Björn Feber]

GB_2 updated this revision to Diff 47033.
GB_2 added a comment.


Add tooltip for the resize button, change tooltip text and increase tooltip timeout.

REPOSITORY
R119 Plasma Desktop

CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D17323?vs=47011&id=47033

REVISION DETAIL
https://phabricator.kde.org/D17323

AFFECTED FILES
desktoppackage/contents/configuration/panelconfiguration/EdgeHandle.qml
desktoppackage/contents/configuration/panelconfiguration/SizeHandle.qml

To: GB_2, #plasma, #vdg
Cc: davidedmundson, matheusm, ngraham, trickyricky26, #vdg, plasma-devel, #plasma, alexde, IohannesPetros, ragreen, Pitel, crozbo, ndavis, ZrenBot, firef, skadinna, lesliezhai, ali-mohamed, jensreuterberg, aaronhoneycutt, abetts, sebas, apol, mbohlender, mart

[Nathaniel Graham]

ngraham accepted this revision.
ngraham added a comment.
This revision is now accepted and ready to land.


This looks great to me now! Just one tiny little minor suggested wording change.

Let's see what the #plasma <https://phabricator.kde.org/tag/plasma/> folks think too.

INLINE COMMENTS

EdgeHandle.qml:39
+ anchors.fill: parent
+ text: i18nd("plasma_shell_org.kde.plasma.desktop", "Click and drag the button to a screen edge to move the panel.")
+ horizontalAlignment: Text.AlignHCenter

Almost perfect text! One small suggestion! `to move the panel.` -> `to move the panel there.`

REPOSITORY
R119 Plasma Desktop

REVISION DETAIL
https://phabricator.kde.org/D17323

To: GB_2, #plasma, #vdg, ngraham
Cc: davidedmundson, matheusm, ngraham, trickyricky26, #vdg, plasma-devel, #plasma, alexde, IohannesPetros, ragreen, Pitel, crozbo, ndavis, ZrenBot, firef, skadinna, lesliezhai, ali-mohamed, jensreuterberg, aaronhoneycutt, abetts, sebas, apol, mbohlender, mart

[Björn Feber]

GB_2 updated this revision to Diff 47038.
GB_2 added a comment.


Improve wording.

REPOSITORY
R119 Plasma Desktop

CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D17323?vs=47033&id=47038

REVISION DETAIL
https://phabricator.kde.org/D17323

AFFECTED FILES
desktoppackage/contents/configuration/panelconfiguration/EdgeHandle.qml
desktoppackage/contents/configuration/panelconfiguration/SizeHandle.qml

To: GB_2, #plasma, #vdg, ngraham
Cc: davidedmundson, matheusm, ngraham, trickyricky26, #vdg, plasma-devel, #plasma, alexde, IohannesPetros, ragreen, Pitel, crozbo, ndavis, ZrenBot, firef, skadinna, lesliezhai, ali-mohamed, jensreuterberg, aaronhoneycutt, abetts, sebas, apol, mbohlender, mart

[Björn Feber]

GB_2 updated this revision to Diff 47041.
GB_2 added a comment.


Fix text color.

REPOSITORY
R119 Plasma Desktop

CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D17323?vs=47038&id=47041

REVISION DETAIL
https://phabricator.kde.org/D17323

AFFECTED FILES
desktoppackage/contents/configuration/panelconfiguration/EdgeHandle.qml
desktoppackage/contents/configuration/panelconfiguration/SizeHandle.qml

To: GB_2, #plasma, #vdg, ngraham
Cc: davidedmundson, matheusm, ngraham, trickyricky26, #vdg, plasma-devel, #plasma, alexde, IohannesPetros, ragreen, Pitel, crozbo, ndavis, ZrenBot, firef, skadinna, lesliezhai, ali-mohamed, jensreuterberg, aaronhoneycutt, abetts, sebas, apol, mbohlender, mart

[Björn Feber]

GB_2 updated this revision to Diff 47045.
GB_2 added a comment.


Fix tooltip text color (for real this time).

REPOSITORY
R119 Plasma Desktop

CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D17323?vs=47041&id=47045

REVISION DETAIL
https://phabricator.kde.org/D17323

AFFECTED FILES
desktoppackage/contents/configuration/panelconfiguration/EdgeHandle.qml
desktoppackage/contents/configuration/panelconfiguration/SizeHandle.qml

To: GB_2, #plasma, #vdg, ngraham
Cc: davidedmundson, matheusm, ngraham, trickyricky26, #vdg, plasma-devel, #plasma, alexde, IohannesPetros, ragreen, Pitel, crozbo, ndavis, ZrenBot, firef, skadinna, lesliezhai, ali-mohamed, jensreuterberg, aaronhoneycutt, abetts, sebas, apol, mbohlender, mart

[Hazem Salem]

Codezela added a comment.


when resizing the panel can we show the width of it
48px ,36px etc
because now when I resize the panel I guess what better visually
but if I know the size exactly It will much better
like all other panels latte dock for example

REPOSITORY
R119 Plasma Desktop

REVISION DETAIL
https://phabricator.kde.org/D17323

To: GB_2, #plasma, #vdg, ngraham
Cc: Codezela, davidedmundson, matheusm, ngraham, trickyricky26, #vdg, plasma-devel, #plasma, alexde, IohannesPetros, ragreen, Pitel, crozbo, ndavis, ZrenBot, firef, skadinna, lesliezhai, ali-mohamed, jensreuterberg, aaronhoneycutt, abetts, sebas, apol, mbohlender, mart

[Björn Feber]

GB_2 added a comment.

Post by Hazem Salem
when resizing the panel can we show the width of it
48px ,36px etc
because now when I resize the panel I guess what better visually
but if I know the size exactly It will much better
like all other panels latte dock for example

It does that already:
F6461758: Panel Edit Mode Buttons (5).png <https://phabricator.kde.org/F6461758>

REPOSITORY
R119 Plasma Desktop

REVISION DETAIL
https://phabricator.kde.org/D17323

To: GB_2, #plasma, #vdg, ngraham
Cc: Codezela, davidedmundson, matheusm, ngraham, trickyricky26, #vdg, plasma-devel, #plasma, alexde, IohannesPetros, ragreen, Pitel, crozbo, ndavis, ZrenBot, firef, skadinna, lesliezhai, ali-mohamed, jensreuterberg, aaronhoneycutt, abetts, sebas, apol, mbohlender, mart

[Hazem Salem]

Codezela added a comment.

Post by Björn Feber

Post by Hazem Salem
when resizing the panel can we show the width of it
48px ,36px etc
because now when I resize the panel I guess what better visually
but if I know the size exactly It will much better
like all other panels latte dock for example

F6461758: Panel Edit Mode Buttons (5).png <https://phabricator.kde.org/F6461758>

sorry for that I don't recognize it
or maybe I was waiting for some kind of tooltip with big numbers

but this is ok
sorry again

REPOSITORY
R119 Plasma Desktop

REVISION DETAIL
https://phabricator.kde.org/D17323

To: GB_2, #plasma, #vdg, ngraham
Cc: Codezela, davidedmundson, matheusm, ngraham, trickyricky26, #vdg, plasma-devel, #plasma, alexde, IohannesPetros, ragreen, Pitel, crozbo, ndavis, ZrenBot, firef, skadinna, lesliezhai, ali-mohamed, jensreuterberg, aaronhoneycutt, abetts, sebas, apol, mbohlender, mart

[Björn Feber]

GB_2 added a comment.


It's okay :-)

REPOSITORY
R119 Plasma Desktop

REVISION DETAIL
https://phabricator.kde.org/D17323

To: GB_2, #plasma, #vdg, ngraham
Cc: Codezela, davidedmundson, matheusm, ngraham, trickyricky26, #vdg, plasma-devel, #plasma, alexde, IohannesPetros, ragreen, Pitel, crozbo, ndavis, ZrenBot, firef, skadinna, lesliezhai, ali-mohamed, jensreuterberg, aaronhoneycutt, abetts, sebas, apol, mbohlender, mart

[Björn Feber]

GB_2 updated this revision to Diff 47058.
GB_2 added a comment.


Hide the tooltip if you click on it.

REPOSITORY
R119 Plasma Desktop

CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D17323?vs=47045&id=47058

REVISION DETAIL
https://phabricator.kde.org/D17323

AFFECTED FILES
desktoppackage/contents/configuration/panelconfiguration/EdgeHandle.qml
desktoppackage/contents/configuration/panelconfiguration/SizeHandle.qml

To: GB_2, #plasma, #vdg, ngraham
Cc: Codezela, davidedmundson, matheusm, ngraham, trickyricky26, #vdg, plasma-devel, #plasma, alexde, IohannesPetros, ragreen, Pitel, crozbo, ndavis, ZrenBot, firef, skadinna, lesliezhai, ali-mohamed, jensreuterberg, aaronhoneycutt, abetts, sebas, apol, mbohlender, mart